Skip to content

DS-1553 outcome time resolution #228

Merged
brunotm merged 8 commits intomasterfrom
DS-1553-time-resolution
Mar 11, 2026
Merged

DS-1553 outcome time resolution #228
brunotm merged 8 commits intomasterfrom
DS-1553-time-resolution

Conversation

@akuzni2
Copy link
Copy Markdown
Contributor

@akuzni2 akuzni2 commented Feb 17, 2026 •
edited
Loading

  • rename precision to resolution as it's the more correct term to use when discussing the actual unit of time in the currently used context.
  • Parse evm_abi_encode_unpacked opts in outcome to determine if a channel is seconds resolution or not.
  • Avoid a cyclic import by moving TimeResolution back into types.go as we reference the TimeResolution inside plugin methods.

Ideally we will re-introduce the channel opts cache as an optimization in the near future.

@akuzni2 akuzni2 marked this pull request as ready for review February 18, 2026 16:11
@akuzni2 akuzni2 requested a review from a team as a code owner February 18, 2026 16:11
@akuzni2 akuzni2 requested a review from brunotm March 9, 2026 18:54
brunotm
brunotm requested changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@brunotm brunotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time resolution changes looks good.

I believe we should leave the quote support outside of this change.

akuzni2 added 2 commits March 11, 2026 08:53
@akuzni2
Remove quote stream support from non legacy codecs
d242a3b
@akuzni2
Merge branch 'master' of github.com:smartcontractkit/chainlink-data-s…
9a22e20 
…treams into DS-1553-time-resolution

# Conflicts:
#	llo/plugin_outcome.go
#	llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked.go
#	llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked_test.go
@akuzni2 akuzni2 requested a review from brunotm March 11, 2026 15:03
@akuzni2
Copy link
Copy Markdown
Contributor Author

akuzni2 commented Mar 11, 2026

Time resolution changes looks good.

I believe we should leave the quote support outside of this change.

Removed quote stream support from the non-legacy codecs (evm_abi and evm_abi_expr)

@brunotm brunotm merged commit 0fcc913 into master Mar 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunotm brunotm brunotm approved these changes

@sharifsc sharifsc Awaiting requested review from sharifsc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akuzni2 @brunotm